Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misc issues #1156

Merged
merged 8 commits into from
Nov 29, 2024
Merged

fix: misc issues #1156

merged 8 commits into from
Nov 29, 2024

Conversation

pateljannat
Copy link
Collaborator

@pateljannat pateljannat commented Nov 27, 2024 •
edited
Loading

  1. Lesson help videos now have titles in the dialog.
  2. Added % symbol to the Progress column of the Program and fixed alignment.
  3. Program titles can now be changed.
  4. Courses in the program that cannot be accessed yet now have an overlay on top indicating they are locked.
  5. Removed the onboarding banner.
  6. Users will now be notified about their marks in the quiz.

@cypress Cypress
Copy link

cypress bot commented Nov 27, 2024 •
edited
Loading

lms    Run #865

Run Properties:  status check passed Passed #865  •  git commit a85d556406 ℹ️: Merge 55ec813f825ca5cc35472e8ee54c1ce86a8d201b into 6329d9c917113047ed62055896c2...
Project lms
Branch Review program-saving-issue
Run status status check passed Passed #865
Run duration 00m 29s
Commit git commit a85d556406 ℹ️: Merge 55ec813f825ca5cc35472e8ee54c1ce86a8d201b into 6329d9c917113047ed62055896c2...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit c471d39 into frappe:develop Nov 29, 2024
5 checks passed
@pateljannat pateljannat deleted the program-saving-issue branch November 29, 2024 11:29
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.15.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot