Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: desk access and course amount validation issue #1150

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix: desk access and course amount validation issue #1150

merged 2 commits into from
Nov 25, 2024

Conversation

pateljannat
Copy link
Collaborator

  1. LMS roles were being created with desk access enabled.
  2. Because of this even students were able to access desk.

@pateljannat pateljannat changed the title fix: disable desk_access for lms roles fix: desk access and course amount issue Nov 25, 2024
@pateljannat pateljannat changed the title fix: desk access and course amount issue fix: desk access and course amount validation issue Nov 25, 2024
@cypress Cypress
Copy link

cypress bot commented Nov 25, 2024 •
edited
Loading

lms    Run #847

Run Properties:  status check passed Passed #847  •  git commit 5914d7ccde ℹ️: Merge d49d6382536d16479dd96ae29aa9a3398b216dc7 into 562020de7030bca2b8ae6ba09b7c...
Project lms
Branch Review roles-desk-access-issue
Run status status check passed Passed #847
Run duration 00m 31s
Commit git commit 5914d7ccde ℹ️: Merge d49d6382536d16479dd96ae29aa9a3398b216dc7 into 562020de7030bca2b8ae6ba09b7c...
Committer Jannat Patel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@pateljannat pateljannat merged commit a90e3d6 into frappe:develop Nov 25, 2024
5 checks passed
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 2.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pateljannat @frappe-pr-bot