Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@W-14689557@: Update user text, README.md, and CONTRIBUTING.md #9

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

stephen-carter-at-sf
Copy link
Contributor

No description provided.

Copy link

@teresa-allen-sfdc teresa-allen-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Stephen! Thanks for writing the Contributing Guide - it looks really good. I did add a big handful of comments throughout, just to elevate your solid draft to CX standards. I explained why to make the various edits with some info in most comments about why CX writes the way we do. Thanks for making the updates!

Also, I sent out the readme UI text review yesterday afternoon. I'll ping you on Slack when the approved text is ready to implement.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@stephen-carter-at-sf stephen-carter-at-sf force-pushed the d/W-14689557 branch 3 times, most recently from 87fdfff to 54fa23d Compare January 19, 2024 20:01
Base automatically changed from d/W-14689540 to main January 22, 2024 17:44
@stephen-carter-at-sf stephen-carter-at-sf marked this pull request as ready for review January 22, 2024 17:46
@stephen-carter-at-sf stephen-carter-at-sf force-pushed the d/W-14689557 branch 2 times, most recently from d5aad4b to 96afddb Compare January 22, 2024 19:49
@stephen-carter-at-sf stephen-carter-at-sf force-pushed the d/W-14689557 branch 3 times, most recently from 3a9f48e to f4faa41 Compare January 23, 2024 14:19
Copy link

@teresa-allen-sfdc teresa-allen-sfdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stephen - thanks for asking me to review! A handful of small updates left to make, but it's looking good. Thanks!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@stephen-carter-at-sf stephen-carter-at-sf merged commit 94c180a into main Jan 23, 2024
15 checks passed
@stephen-carter-at-sf stephen-carter-at-sf deleted the d/W-14689557 branch January 23, 2024 15:56
the results as a job summary.

# Inputs
* `run-command` (Default value: `'run'`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephen-carter-at-sf I just noticed something that we should update throughout this file: we don't need any single quotes around code - just code case like run and not 'run' (code case and quotes). Do you want me to comment on each time I see this, or could you updated all to code case without also having single quotes? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants