-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-14689557@: Update user text, README.md, and CONTRIBUTING.md #9
Conversation
f7422bf
to
739a3c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Stephen! Thanks for writing the Contributing Guide - it looks really good. I did add a big handful of comments throughout, just to elevate your solid draft to CX standards. I explained why to make the various edits with some info in most comments about why CX writes the way we do. Thanks for making the updates!
Also, I sent out the readme UI text review yesterday afternoon. I'll ping you on Slack when the approved text is ready to implement.
739a3c8
to
e1abf37
Compare
ae84dc8
to
8cb5489
Compare
87fdfff
to
54fa23d
Compare
54fa23d
to
7967312
Compare
d5aad4b
to
96afddb
Compare
3a9f48e
to
f4faa41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stephen - thanks for asking me to review! A handful of small updates left to make, but it's looking good. Thanks!
f4faa41
to
e0ade8d
Compare
e0ade8d
to
824f568
Compare
the results as a job summary. | ||
|
||
# Inputs | ||
* `run-command` (Default value: `'run'`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stephen-carter-at-sf I just noticed something that we should update throughout this file: we don't need any single quotes around code - just code case like run
and not 'run'
(code case and quotes). Do you want me to comment on each time I see this, or could you updated all to code case without also having single quotes? Thanks!
No description provided.