Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aerc): make night theme diff colors more readable #654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calebdw
Copy link

@calebdw calebdw commented Oct 28, 2024

Description

Hello!

This closes #653 by making the diff more readable.

Screenshots

Before

image

After

image

Thanks!

@calebdw calebdw changed the title fix(aerc): make diff colors more readable fix(aerc): make night theme diff colors more readable Oct 28, 2024
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the stale label Nov 28, 2024
@calebdw
Copy link
Author

calebdw commented Nov 28, 2024

@folke, can this be merged? Thanks!

@github-actions github-actions bot removed the stale label Nov 29, 2024
@folke
Copy link
Owner

folke commented Dec 15, 2024

extras are auto-generated, so I can't merge this.
You need to update the templates instead.

@calebdw
Copy link
Author

calebdw commented Dec 17, 2024

Ah, I see now---I've update the template and here's how the diff now looks:

image

@calebdw
Copy link
Author

calebdw commented Jan 2, 2025

@folke, just pinging you about the update, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: aerc code diff is too hard to see when using night theme
2 participants