Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow 101 fix to cope with the last Flow API. #147

Merged
merged 6 commits into from
Apr 25, 2019
Merged

Flow 101 fix to cope with the last Flow API. #147

merged 6 commits into from
Apr 25, 2019

Conversation

delabassee
Copy link
Contributor

Fix for #134, Flow 102 will be done next.

@denismakogon
Copy link
Member

@michael-w-williams can you please check what's going on with github/pages check.

@delabassee
Copy link
Contributor Author

@michael-w-williams can you check this?

@michael-w-williams
Copy link
Member

I've asked Thom about this and cc'ed both of you. By the way, I can merge this if you think its ready. Let me know.

@delabassee
Copy link
Contributor Author

Can you just quickly go through the wordings before merging?

michael-w-williams
michael-w-williams approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@michael-w-williams michael-w-williams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through it and it looks good to me. Sorry it has taken so long to get this merged!

@michael-w-williams michael-w-williams merged commit 4019f20 into fnproject:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-w-williams michael-w-williams michael-w-williams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delabassee @denismakogon @michael-w-williams