Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set stable automatic module names #189

Closed
wants to merge 4 commits into from

Conversation

sormuras
Copy link

Draft PR setting com.fnproject.fn.api as the automatic module name for fdk-java/api module. I'd be happy to extend this PR to all other relevant modules.

Addresses #188

@fn-bot
Copy link

fn-bot commented Mar 14, 2019

CLA Bot

Thank you for your submission! It appears that the following authors have not signed our Contributor License Agreement:

Please do so now by visiting http://www.oracle.com/technetwork/community/oca-486395.html

Once complete, let us know in our community Slack and we’ll send you an Fn T-shirt.

We are working on modernizing the CLA process into a digital signature but it isn’t quite ready yet.

Thank you for being a part of the Fn Community!

1 similar comment
@fn-bot
Copy link

fn-bot commented Mar 14, 2019

CLA Bot

Thank you for your submission! It appears that the following authors have not signed our Contributor License Agreement:

Please do so now by visiting http://www.oracle.com/technetwork/community/oca-486395.html

Once complete, let us know in our community Slack and we’ll send you an Fn T-shirt.

We are working on modernizing the CLA process into a digital signature but it isn’t quite ready yet.

Thank you for being a part of the Fn Community!

@sormuras
Copy link
Author

Dear "cla_bot", I already signed the CLA. Find "Christian Stein - OpenJDK - sor" at https://www.oracle.com/technetwork/community/oca-486395.html#s

@delabassee
Copy link
Contributor

@sormuras indeed, let us check how to make the bot happy

@sormuras
Copy link
Author

sormuras commented Apr 3, 2019

@delabassee Any news here? Happy bot in sight?

@sormuras sormuras marked this pull request as ready for review May 2, 2019 07:22
@sormuras
Copy link
Author

Now it reads Christian Stein - OpenJDK / Fn Project - sor but the bot is still unhappy.

@fn-bot
Copy link

fn-bot commented Jun 17, 2019

CLA Bot

All committers have signed the CLA.

@sormuras
Copy link
Author

Closing due to ... today, FDK-Java should ship as explicit Java modules.

@sormuras sormuras closed this Feb 15, 2021
@sormuras sormuras deleted the automatic-module-names branch February 15, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants