[webview_flutter_lwe] Supports multiple JavaScriptChannel method call #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSUYA
added a commit
to JSUYA/plugins
that referenced
this pull request
Jun 18, 2024
This is the same issue as webview_flutter_lwe. refer to flutter-tizen#693 This supports the case of calling multiple JavaScriptChannel methods.
This was referenced Jun 18, 2024
swift-kim
reviewed
Jun 19, 2024
Previously, javascript channel methods that are called
before the webview is created are stored in the pending list.(based on name)
Because of that, there was a problem with channels being missing
when adding multiple channels.
When the javascript channel method is called,
it is stored differently depending on the name to prevent it from being missed.
```dart
controller
..addJavaScriptChannel(
'method1',...)
..addJavaScriptChannel(
'method2',...);
```
JSUYA
force-pushed
the
webview_lwe_multi_channel
branch
from
197ab89 to
e9b3c96
Compare
|
rebased |
JSUYA
added a commit
to JSUYA/plugins
that referenced
this pull request
Jun 20, 2024
This is the same issue as webview_flutter_lwe. refer to flutter-tizen#693 This supports the case of calling multiple JavaScriptChannel methods.
swift-kim
approved these changes
Jun 20, 2024
swift-kim
approved these changes
Jun 20, 2024
xiaowei-guan
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, javascript channel methods that are called before the webview is created are stored in the pending list.(based on name) Because of that, there was a problem with channels being missing when adding multiple channels.
When the javascript channel method is called,
it is stored differently depending on the name to prevent it from being missed.