Minor codes cleanup

flutter-tizen · Oct 25, 2023 · ca3e1a3 · ca3e1a3
1 parent a581e71
commit ca3e1a3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/packages/video_player/tizen/src/video_player.cc b/packages/video_player/tizen/src/video_player.cc
@@ -114,7 +114,7 @@ VideoPlayer::VideoPlayer(flutter::PluginRegistrar *plugin_registrar,
   sink_event_pipe_ = ecore_pipe_add(
       [](void *data, void *buffer, unsigned int nbyte) -> void {
         auto *self = static_cast<VideoPlayer *>(data);
-        self->ExecuteSinkEvents();
+        self->SendPendingEvents();
       },
       this);
 
@@ -212,7 +212,7 @@ VideoPlayer::~VideoPlayer() {
   }
 }
 
-void VideoPlayer::ExecuteSinkEvents() {
+void VideoPlayer::SendPendingEvents() {
   std::lock_guard<std::mutex> lock(queue_mutex_);
   while (!encodable_event_queue_.empty()) {
     if (event_sink_) {
@@ -230,8 +230,8 @@ void VideoPlayer::ExecuteSinkEvents() {
   }
 }
 
-void VideoPlayer::PushEvent(flutter::EncodableValue encodable_value) {
-  if (event_sink_ == nullptr) {
+void VideoPlayer::PushEvent(const flutter::EncodableValue &encodable_value) {
+  if (!event_sink_) {
     LOG_ERROR("[VideoPlayer] event sink is nullptr.");
     return;
   }
@@ -242,7 +242,7 @@ void VideoPlayer::PushEvent(flutter::EncodableValue encodable_value) {
 
 void VideoPlayer::SendError(const std::string &error_code,
                             const std::string &error_message) {
-  if (event_sink_ == nullptr) {
+  if (!event_sink_) {
     LOG_ERROR("[VideoPlayer] event sink is nullptr.");
     return;
   }

diff --git a/packages/video_player/tizen/src/video_player.h b/packages/video_player/tizen/src/video_player.h
@@ -44,8 +44,8 @@ class VideoPlayer {
   int64_t GetTextureId() { return texture_id_; }
 
  private:
-  void ExecuteSinkEvents();
-  void PushEvent(flutter::EncodableValue encodable_value);
+  void SendPendingEvents();
+  void PushEvent(const flutter::EncodableValue &encodable_value);
   void SendError(const std::string &error_code,
                  const std::string &error_message);
   FlutterDesktopGpuSurfaceDescriptor *ObtainGpuSurface(size_t width,