Skip to content

Commit

Permalink
Sync accessibility flags in embedder.h (#264)
Browse files Browse the repository at this point in the history
The following enum types in `embedder.h` must match with the corresponding Dart/C++ classes in `dart:ui` but some values are missing.

- `FlutterAccessibilityFeature`
- `FlutterSemanticsAction`
- `FlutterSemanticsFlag`

The comments say

https://github.com/flutter/engine/blob/2d29e2f3b5e4c951809eb7578ff5f114f91efbeb/shell/platform/embedder/embedder.h#L83

https://github.com/flutter/engine/blob/2d29e2f3b5e4c951809eb7578ff5f114f91efbeb/lib/ui/window.dart#L784-L785
  • Loading branch information
swift-kim authored Apr 7, 2022
1 parent e36df21 commit 3038c66
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion shell/platform/embedder/embedder.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,10 @@ typedef enum {
/// Request that text be rendered at a bold font weight.
kFlutterAccessibilityFeatureBoldText = 1 << 3,
/// Request that certain animations be simplified and parallax effects
// removed.
/// removed.
kFlutterAccessibilityFeatureReduceMotion = 1 << 4,
/// Request that UI be rendered with darker colors.
kFlutterAccessibilityFeatureHighContrast = 1 << 5,
} FlutterAccessibilityFeature;

/// The set of possible actions that can be conveyed to a semantics node.
Expand Down Expand Up @@ -148,6 +150,8 @@ typedef enum {
kFlutterSemanticsActionMoveCursorForwardByWord = 1 << 19,
/// Move the cursor backward by one word.
kFlutterSemanticsActionMoveCursorBackwardByWord = 1 << 20,
/// Replace the current text in the text field.
kFlutterSemanticsActionSetText = 1 << 21,
} FlutterSemanticsAction;

/// The set of properties that may be associated with a semantics node.
Expand Down Expand Up @@ -202,6 +206,12 @@ typedef enum {
/// `PageView` widget does not have implicit scrolling, so that users don't
/// navigate to the next page when reaching the end of the current one.
kFlutterSemanticsFlagHasImplicitScrolling = 1 << 18,
/// Whether the value of the semantics node is coming from a multi-line text
/// field.
///
/// This is used for text fields to distinguish single-line text fields from
/// multi-line ones.
kFlutterSemanticsFlagIsMultiline = 1 << 19,
/// Whether the semantic node is read only.
///
/// Only applicable when kFlutterSemanticsFlagIsTextField flag is on.
Expand Down

0 comments on commit 3038c66

Please sign in to comment.