Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo how offset vector $\vec{f}$ is calculated #7

Open
wants to merge 25 commits into
base: new-ragtimer-format
Choose a base branch
from

Conversation

ifndefJOSH
Copy link
Collaborator

@ifndefJOSH ifndefJOSH commented May 17, 2024

Previously there was an error in how the offset vector $\vec{f}$ was calculated. It would find vector $\vec{v}$ as the shortest distance from $S_n$ to $S_s$, and then project onto $S_0$. Problem was that this would often yield $\vec{0}$ as since $S_n \in S_0$ the shortest distance to $S_s$ was perpendicular to $S_n$ and thus $S_0$. This PR computes $S_s \cap S_0$ first and then computes the distance from $S_n$ to that intersection.

@ifndefJOSH ifndefJOSH changed the title Add redo for offset vectors Redo how offset vector $\vec{f}$ is calculated May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant