-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tensor shapes for elementwise binary operations with broadcasting #738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiazhihao
approved these changes
May 28, 2023
The PR lgtm. However, it seems the changes do not pass the following test
|
soumyac1999
force-pushed
the
broadcast_shapes
branch
2 times, most recently
from
October 13, 2023 07:46
3691d6f
to
2dbc18c
Compare
soumyac1999
force-pushed
the
broadcast_shapes
branch
from
October 13, 2023 07:52
c607943
to
2dbc18c
Compare
@jiazhihao, similar fixes were needed in Keras to correctly compute the output shapes. This test now passes (alteast locally, waiting for the CI checks). |
…xFlow into broadcast_shapes
1 task
Moved to #1234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Example:
[16, 1, 2] + [16, 1552, 1]
has output shape of[16, 1552, 2]
but the existing code was setting the size to[16, 1, 2]
.Related Issues:
Linked Issues:
Issues closed by this PR:
Before merging:
This change is