Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build: default to lib instead of lib64 #1037

Closed
wants to merge 3 commits into from

Conversation

eschmidbauer
Copy link

@eschmidbauer eschmidbauer commented Aug 28, 2023

Description of changes:
Fix build in conda env & nvidia packages

cd FlexFlow
conda env create -f conda/environment.yml
conda activate flexflow
conda install -c "nvidia" \
  cuda \
  cuda-toolkit \
  cuda-nvcc \
  cudnn

mkdir build
cd build

cmake \
  -DCUDA_USE_STATIC_CUDA_RUNTIME=OFF \
  -DLegion_HIJACK_CUDART=OFF \
  -DINFERENCE_TESTS=OFF \
  -DLIBTORCH_PATH=~/libtorch \
  -DCMAKE_BUILD_TYPE=Release \
  -DFF_CUDA_ARCH=autodetect \
  -DCUDA_PATH=~/miniconda3/envs/flexflow \
  -DCUDNN_PATH=~/miniconda3/envs/flexflow \
  -DFF_USE_PYTHON=ON \
  -DFF_USE_NCCL=ON \
  -DNCCL_PATH=/usr/local/cuda \
  -DFF_BUILD_ALL_EXAMPLES=OFF \
  -DFF_BUILD_ALL_INFERENCE_EXAMPLES=ON \
  -DFF_USE_PREBUILT_LEGION=OFF \
  -DFF_USE_PREBUILT_NCCL=OFF \
  -DFF_USE_ALL_PREBUILT_LIBRARIES=OFF \
  -DFF_BUILD_UNIT_TESTS=OFF \
  -DFF_USE_AVX2=OFF \
  -DFF_MAX_DIM=5 \
  -DLEGION_MAX_RETURN_SIZE=262144 \
  -DROCM_PATH=/opt/rocm \
  -DFF_GPU_BACKEND=cuda ../config/../

make -j

This change is Reviewable

Copy link
Collaborator

@goliaro goliaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eschmidbauer, could you let us know why this change is needed? It looks like some changes may be needed to make this work, so if I have a better understanding of what problem we're trying to solve, I can help! Thanks!

@eschmidbauer
Copy link
Author

Hi @eschmidbauer, could you let us know why this change is needed? It looks like some changes may be needed to make this work, so if I have a better understanding of what problem we're trying to solve, I can help! Thanks!

I had to make this change in order to build it on ubuntu 22.04. Please disregard if there is another way to make this build on ubuntu

@jiazhihao
Copy link
Collaborator

Close this PR since we can successfully run FF without the path change.

@jiazhihao jiazhihao closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants