Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: local -> external builder mapping #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

namn-grg
Copy link

Overview

This PR adds payload ID mapping functionality to track and map between local and external payload IDs when interacting with the builder node. This ensures proper correlation between payloads across different nodes.

Key changes:

  • Added local_to_external_payload_ids cache to PayloadTraceContext to store mappings
  • Added methods to store and retrieve payload ID mappings
  • Updated get_payload_v3 to use external payload ID when requesting from builder
  • Added payload ID mapping in fork_choice_updated_v3 response handling
  • Added logging improvements to track both local and external payload IDs

The changes help maintain proper tracing and correlation between local execution engine payloads and external builder payloads, improving debuggability and reliability of the system.

solves #46

@namn-grg namn-grg changed the title chore: mapping builder chore: local -> external builder mapping Jan 14, 2025
@namn-grg
Copy link
Author

@avalonche can you pls check if the logic makes sense?
Its currently failing failing test

'server::tests::test_server' panicked at src/server.rs:760:9:
assertion `left == right` failed
  left: 0
 right: 1

@dmarzzz
Copy link
Member

dmarzzz commented Jan 15, 2025

thanks for the PR! will review soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants