Clean-up Makefile and use docker buildx locally #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
approved these changes
Feb 26, 2024
thomasferrandiz
force-pushed
the
cleanup-makefile
branch
from
5afe956 to
c729650
Compare
thomasferrandiz
changed the title
The Makefile has many unused targets that were making it large and confusing. Now that the CI is using docker buildx we can remove some of the qemu-based build targets. We can also simplify some of the GH workflows that were building the same files multiple times.
thomasferrandiz
force-pushed
the
cleanup-makefile
branch
from
c729650 to
e90a170
Compare
manuelbuil
requested changes
Feb 27, 2024
manuelbuil
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Makefile has many unused targets that were making it large and
confusing.
Now that the CI is using docker buildx we can remove some of the
qemu-based build targets.
We can also simplify some of the GH workflows that were building the
same files multiple times.
Todos
Release Note