Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support to select the interface in Windows #1855

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Provide support to select the interface in Windows #1855

merged 1 commit into from
Jan 16, 2024

Conversation

manuelbuil
Copy link
Collaborator

@manuelbuil manuelbuil commented Jan 12, 2024 •
edited
Loading

Description

This PR does two things:

  • Extends support of the flag --iface to windows.
  • Exits if we are in Windows and use the flag --iface-can-reach

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Support --iface in Windows

@thomasferrandiz
Copy link
Contributor

is there a way to add a test for this feature?

@thomasferrandiz
Copy link
Contributor

is there a way to add a test for this feature?

nvm we don't have windows runners for the moment

@manuelbuil manuelbuil merged commit 761c257 into flannel-io:master Jan 16, 2024
8 checks passed
@manuelbuil manuelbuil deleted the addIfPickWin branch January 16, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasferrandiz thomasferrandiz thomasferrandiz approved these changes

@rbrtbnfgl rbrtbnfgl rbrtbnfgl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manuelbuil @thomasferrandiz @rbrtbnfgl