Add Private Links #328
Merged
Add Private Links #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2024
fivetran-aleksandrboldyrev
force-pushed
the
private_links
branch
2 times, most recently
from
5db33e5 to
4cbb8fd
Compare
fivetran-aleksandrboldyrev
requested review from
beevital and
fivetran-jovanmanojlovic
beevital
requested changes
Oct 28, 2024
There was a problem hiding this comment.
I see here several problems:
- I don't like we mix up renaming LocalProcessingAgent -> HybridDeploymentAgent with PLs logic. I must be a separate PR
- Configuration for PLs on API side isn't final. But we already introduce here some contract that we will have to maintain later and probably migrate.
- Does it worth right now to introduce strict PL config? maybe it worth to make it just a map?
fivetran-aleksandrboldyrev
force-pushed
the
private_links
branch
from
192ee5b to
d4a90e9
Compare
fivetran-aleksandrboldyrev
force-pushed
the
private_links
branch
from
f946673 to
a9b7c2f
Compare
beevital
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.