-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workday employee daily history model + monthly summary model + updates to employee surrogate key #5
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
0321faa
Add employee daily history model, update surrogate key on employee ov…
fivetran-avinash 1a90305
Workday history upgrades
fivetran-avinash 810af8d
Workday history upgrades
fivetran-avinash 9effe38
Workday history upgrades
fivetran-avinash 9641fdf
More employee monthly metrics
fivetran-avinash e6b0bce
Incremental logic
fivetran-avinash 8fadd3a
employee history config
fivetran-avinash 3e1038a
syntax
fivetran-avinash 4bcd1d1
Variable configs, removing incremental logic, documentation and yml u…
fivetran-avinash a91d72b
add worker-position-org history model and documentation
fivetran-avinash 62a1fa0
model & documentation updates
fivetran-avinash 533e466
PR review notes
fivetran-avinash 20ce0ec
review/jm-datespine-edits
fivetran-joemarkiewicz 84826e9
final changes to compile properly
fivetran-joemarkiewicz 5cf4a29
Merge pull request #6 from fivetran/review/jm-datespine-edits
fivetran-avinash b625b80
Joe PR fixes
fivetran-avinash 7ae41b3
regen docs
fivetran-avinash bb54ce6
PR review fixes, yml documentation
fivetran-avinash 9631d50
changelog
fivetran-avinash db43f0e
PR re-review
fivetran-avinash 72b79a2
PR final review
fivetran-avinash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
## On not adding incremental logic into the Workday HCM History models | ||
Generally, when working with large volume models like the ones created by Fivetran History Mode, we tend to implement incremental models. [See Salesforce](https://github.com/fivetran/dbt_salesforce?tab=readme-ov-file#optional-step-4-utilizing-salesforce-history-mode-records) for a particular example of that implementation. | ||
|
||
However, in the Workday HCM case, we have found that History Mode does not fit the use case for incremental logic due to the following reasons. | ||
* Transactions can be future-dated. The most common case is an employee being hired for a future date beyond the current date, so an incremental run will pick up numerous records in the future, leading to potential duplications down the road for an employee's records. | ||
* There are additional cases where an employee's record can be updated in the past beyond a common incremental window. | ||
|
||
We welcome all attempts to optimize this strategy though, and would be open to enhancements to the package! | ||
|
||
## Why we kept the worker position organization history model separate from the employee daily history model | ||
|
||
The intent of the `workday__employee_daily_history` model was to combine historical data from all relevant worker history models and gather a daily look at that data based on employee and worker. | ||
|
||
However, with `stg_workday__worker_position_organization_history`, the values for organization are too customizable, and thus impossible to just into an `employee_daily_history` model with any clear definitions. | ||
|
||
Instead we have decided to keep the model separate in `workday__worker_position_org_history`, leaving end customers the ability to configure what organizations they end up joining into the employee daily history within their warehouses. The `int_workday__employee_history` model provides a solid guide into configuring your own custom-type history mode model. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is technically a breaking change as the old views are now going to be stale. I would call this out in the CHANGELOG as a breaking change and inform customers that the previous staging views will no longer be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, don't forget to add the link to the PR in the CHANGELOG for all these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to the CHANGELOG.