-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add var for CALL
+ update way we disable source freshness
#6
Changes from all commits
33742f3
c2ac0d5
48e16c2
91bd076
32c70c1
048a74d
e34f0c2
79ce9db
85f8507
df35848
ef2f462
c19191c
8c7ee3d
a1f3ac1
394aba7
765fd5a
f6ce4d3
b603737
a036941
eb866af
afb0356
ab334d7
8a20b75
7c36487
bfd7b4a
d289b30
a55340d
be98c86
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
name: 'auto release' | ||
on: | ||
pull_request: | ||
types: | ||
- closed | ||
branches: | ||
- main | ||
|
||
jobs: | ||
call-workflow-passing-data: | ||
if: github.event.pull_request.merged | ||
uses: fivetran/dbt_package_automations/.github/workflows/auto-release.yml@main | ||
secrets: inherit |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,22 @@ | ||
# dbt_twilio_source v0.2.0 | ||
|
||
## 🚨 Breaking Changes 🚨 | ||
- Under the hood, we've updated the `_tmp` models to use the `dbt_utils.star` macro instead of a basic `select *` ([PR #6](https://github.com/fivetran/dbt_twilio_source/pull/6)). | ||
- This means that you can no longer use `var(<table_name>)` to override the source tables we create staging models from. Instead, see the [README](https://github.com/fivetran/dbt_twilio_source?tab=readme-ov-file#change-the-source-table-references) for how to use our `_identifier` variables. | ||
- Removed the deprecated `twilio_using_message` variable. This is a breaking change because you could previously use this variable to disable freshness tests on the `MESSAGE` source table. To continue to do so, leverage dbt [overrides](https://docs.getdbt.com/reference/resource-properties/overrides#configure-your-own-source-freshness-for-a-source-table-in-a-package) to set `message`'s freshness to `null` ([PR #6](https://github.com/fivetran/dbt_twilio_source/pull/6)). | ||
|
||
## Features | ||
- Added the ability to disable models related to the `CALL` source table. Refer to the [README](https://github.com/fivetran/dbt_twilio_source?tab=readme-ov-file#step-4-enablingdisabling-models) for more details ([PR #5](https://github.com/fivetran/dbt_twilio_source/pull/5)). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar question regarding There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just a stylistic choice - i tend to capitalize raw source tables in documentation to highlight that they're not package models or columns |
||
|
||
## Under the Hood | ||
- Adjusted the case of loader name from `fivetran` to `Fivetran` in the `src_twilio.yml` file ([PR #5](https://github.com/fivetran/dbt_twilio_source/pull/5)). | ||
- Adjusted the way we dynamically disable source freshness tests for tables that may be missing to use dbt's native `config.enabled` [flag](https://docs.getdbt.com/reference/resource-configs/enabled) ([PR #6](https://github.com/fivetran/dbt_twilio_source/pull/6)). | ||
- Updated the pull request [templates](/.github) ([PR #6](https://github.com/fivetran/dbt_twilio_source/pull/6)). | ||
- Included auto-releaser GitHub Actions workflow to automate future releases ([PR #6](https://github.com/fivetran/dbt_twilio_source/pull/6)). | ||
|
||
## Contributors | ||
- [@raphaelvarieras](https://github.com/raphaelvarieras) ([PR #5](https://github.com/fivetran/dbt_twilio_source/pull/5)) | ||
|
||
# dbt_twilio_source v0.1.0 | ||
|
||
## Initial Release | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
|
||
name: 'twilio_source' | ||
version: '0.1.0' | ||
version: '0.2.0' | ||
config-version: 2 | ||
|
||
models: | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,5 @@ | |
target/ | ||
dbt_modules/ | ||
logs/ | ||
.DS_Store | ||
.DS_Store | ||
package-lock.yml |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
select * | ||
select {{ dbt_utils.star(source('twilio', 'account_history')) }} | ||
fivetran-joemarkiewicz marked this conversation as resolved.
Show resolved
Hide resolved
|
||
from {{ var('account_history') }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
select * | ||
select {{ dbt_utils.star(source('twilio', 'address')) }} | ||
from {{ var('address') }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,5 @@ | ||
select * | ||
--To disable this model, set the using_twilio_call variable within your dbt_project.yml file to False. | ||
{{ config(enabled=var('using_twilio_call', True)) }} | ||
|
||
select {{ dbt_utils.star(source('twilio', 'call')) }} | ||
from {{ var('call') }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
select * | ||
select {{ dbt_utils.star(source('twilio', 'incoming_phone_number')) }} | ||
from {{ var('incoming_phone_number') }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
select * | ||
select {{ dbt_utils.star(source('twilio', 'message')) }} | ||
from {{ var('message') }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
--To disable this model, set the using_domain_names variable within your dbt_project.yml file to False. | ||
--To disable this model, set the using_twilio_messaging_service variable within your dbt_project.yml file to False. | ||
{{ config(enabled=var('using_twilio_messaging_service', True)) }} | ||
|
||
select * | ||
select {{ dbt_utils.star(source('twilio', 'messaging_service')) }} | ||
from {{ var('messaging_service') }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
select * | ||
select {{ dbt_utils.star(source('twilio', 'outgoing_caller_id')) }} | ||
from {{ var('outgoing_caller_id') }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
select * | ||
select {{ dbt_utils.star(source('twilio', 'usage_record')) }} | ||
from {{ var('usage_record') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know why we're capitalizing
MESSAGE
here? The source table ismessage
in thedbt_project.yml
. Is it because the customer is using Snowflake?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just capitalizing it to highlight it as a source table (as opposed to a package model or a column)