Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused models #11

Closed
wants to merge 6 commits into from
Closed

remove unused models #11

wants to merge 6 commits into from

Conversation

fivetran-reneeli
Copy link
Contributor

@fivetran-reneeli fivetran-reneeli commented Nov 15, 2024

PR Overview

This PR will address the following Issue/Feature:
#10
This PR will result in the following new package version: v0.4.0

Breaking change since this removes some models from the schema.

Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:

  • Removes the following models that are unused downstream, along with their related files and mentions.
    • stg_twilio__address
    • stg_twilio__incoming_phone_number
    • stg_twilio__outgoing_caller_id

PR Checklist

Basic Validation

Please acknowledge that you have successfully performed the following commands locally:

  • dbt run –full-refresh && dbt test
  • [na] dbt run (if incremental models are present) && dbt test

Before marking this PR as "ready for review" the following have been applied:

  • The appropriate issue has been linked, tagged, and properly assigned
  • All necessary documentation and version upgrades have been applied
  • docs were regenerated (unless this PR does not include any code or yml updates)
  • BuildKite integration tests are passing
  • Detailed validation steps have been provided below

Detailed Validation

Please share any and all of your validation steps:

Not much validation since these models were not used in the first place, but just ensuring that the models are removed in the documentation and in any mentions downstream.

If you had to summarize this PR in an emoji, which would it be?

💃

@fivetran-reneeli fivetran-reneeli changed the title rm address and incoming_phone_number models remove unused models Nov 15, 2024
@fivetran-reneeli fivetran-reneeli linked an issue Nov 18, 2024 that may be closed by this pull request
4 tasks
@fivetran-reneeli fivetran-reneeli self-assigned this Nov 18, 2024
@@ -1,3 +1,5 @@
{{ config(enabled=var('using_twilio_usage_record', True)) }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our standard way would be twilio__using_usage_record, but then I should also update using_twilio_call and using_twilio_messaging_service, which would require users who already have those variables configured to change it, which would be more of a hassle customer-experience wise.

@fivetran-reneeli
Copy link
Contributor Author

As discussed internally, it makes sense to keep the unused staging models if they're not being run and materialized via the end models in Quickstart. We can keep them here so that users who may be only using the respective staging models can still access them, with no risk for errors downstream. As such, I'll remove this PR and open a separate one just for adding the disable config for usage_record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Add support for
1 participant