Create redshift limit one macro #95
Open
+400
−80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR will address the following Issue/Feature: Internal ticket
This PR will result in the following new package version:
v0.15.0 - staging model results will be different for redshift users potentially (1 row instead of 0 for empty rows)
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Under the Hood
shopify_union_data
macro to accommodate Redshift's treatment of empty tables.null
row for Redshift destinations.varchar
. This throws errors in downstream transformations in theshopify
package. The 1 row will ensure that Redshift will respect the package's datatype casts.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
See concurrent transform PR.
If you had to summarize this PR in an emoji, which would it be?
🇪🇺