Update variable declarations #155
Conversation
| @@ -11,9 +11,9 @@ vars: | |||
| netsuite_schema: netsuite_integration_tests_8 | |||
| netsuite_data_model_override: netsuite | |||
|
|
|||
| # # Enable below when generating docs | |||
| # netsuite2__multibook_accounting_enabled: true | |||
| # netsuite2__using_to_subsidiary: true | |||
There was a problem hiding this comment.
Obligatory reminder: Does this need to be uncommented before merge?
There was a problem hiding this comment.
No, this only needs to enabled when doing the docs generation. After that, it should be commented back out.
There was a problem hiding this comment.
Oh i meant re-commented*
There was a problem hiding this comment.
Oh d'oh. Yes, should be recommented.
| @@ -1,3 +1,4 @@ | |||
| packages: | |||
| - package: fivetran/netsuite_source | |||
| version: [">=0.11.0", "<0.12.0"] | |||
There was a problem hiding this comment.
Obligatory reminder to update this before release
| revision: update/netsuite-variable-declarations | ||
| warn-unpinned: false |
There was a problem hiding this comment.
| - git: https://github.com/fivetran/dbt_netsuite_source.git | |
| revision: update/netsuite-variable-declarations | |
| warn-unpinned: false | |
| - package: fivetran/netsuite_source | |
| version: [">=0.11.0", "<0.12.0"] |
There was a problem hiding this comment.
Thanks @fivetran-avinash, a few questions and comments before approval.
| [PR #155](https://github.com/fivetran/dbt_netsuite/pull/155) includes the following updates: | ||
|
|
||
| ## Macro Updates | ||
| - Introduced a local version of the `persist_pass_through_columns` macro that directly calls the variables within our models. This removes the existing string-to-variable conversion and leads to cleaner parsing. |
There was a problem hiding this comment.
Same as the comment from the source, can we include a note here that no changes are required by the customer following this update.
| @@ -67,19 +67,19 @@ income_statement as ( | |||
| subsidiaries.name as subsidiary_name | |||
|
|
|||
| --The below script allows for accounts table pass through columns. | |||
| {{ fivetran_utils.persist_pass_through_columns('accounts_pass_through_columns', identifier='accounts') }}, | |||
| {{ netsuite.persist_pass_through_columns(var('accounts_pass_through_columns', none), identifier='accounts') }}, | |||
There was a problem hiding this comment.
Is there a reason we use None here and not [] like we usually do?
There was a problem hiding this comment.
Especially since that's how we have it defined in the dbt_project.yml
There was a problem hiding this comment.
Oh, I was following what was defined in our persist passthrough macro code and assumed the none condition was what we wanted. Updated this in all macro calls.
PR Overview
This PR will address the following Issue/Feature: Internal height ticket
This PR will result in the following new package version: 0.17.1
Please provide the finalized CHANGELOG entry which details the relevant changes included in this PR:
Macro Updates
persist_pass_through_columnsmacro that directly calls the variables within our models. This removes the existing string-to-variable conversion and leads to cleaner parsing.persist_pass_through_columnsmacro.netsuite__*andnetsuite2__*includebalance_sheet,income_statement,transaction_details.PR Checklist
Basic Validation
Please acknowledge that you have successfully performed the following commands locally:
Before marking this PR as "ready for review" the following have been applied:
Detailed Validation
Please share any and all of your validation steps:
Ran on multiple variations of passthrough columns (with name, with alias, with multiple passthrough columns, with no passthrough columns).
If you had to summarize this PR in an emoji, which would it be?
🚲