Merge pull request #71 from fivetran/bugfix/twitter-microsoft-keyword…

…s-search Bugfix/twitter microsoft keywords search
fivetran · Nov 30, 2022 · fad212a · fad212a
2 parents 8c30e5d + 97ca1de
commit fad212a
Show file tree

Hide file tree

Showing 9 changed files with 20 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,13 @@
+# dbt_ad_reporting v1.0.4
+## Feature Enhancement
+- The `keyword_id` field (which is a surrogate key generated from the combination of 'account_id', 'line_item_id', 'segment', and 'placement' fields within the Twitter Ads source) has been added to the `ad_reporting__keyword_report` model for the Twitter Ads platform. ([#71](https://github.com/fivetran/dbt_ad_reporting/pull/71))
+
+## Bugfixes
+- The `not_null` test on the `ad_reporting__keyword_report` has been adjusted to be tested on the `keyword_id` as opposed to the `keyword_text`. This is needed as there may be times where keyword historical records may be removed and lose reference in an upstream join. As such, the text may be lost and the null test should be applied to the ID instead. ([#71](https://github.com/fivetran/dbt_ad_reporting/pull/71))
+
+## Contributors
+- [@clay-walker](https://github.com/clay-walker) for being instrumental in understanding and addressing this issue. ([#63](https://github.com/fivetran/dbt_ad_reporting/issues/63))
+
 # dbt_ad_reporting v1.0.2-v1.0.3
 
 ## 🕷️ Bugfixes 🕷️

diff --git a/dbt_project.yml b/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'ad_reporting'
-version: '1.0.3'
+version: '1.0.4'
 config-version: 2
 
 require-dbt-version: [">=1.0.0", "<2.0.0"]

diff --git a/docs/catalog.json b/docs/catalog.json
diff --git a/docs/manifest.json b/docs/manifest.json
diff --git a/docs/run_results.json b/docs/run_results.json
diff --git a/integration_tests/dbt_project.yml b/integration_tests/dbt_project.yml
@@ -1,5 +1,5 @@
 name: 'ad_reporting_integration_tests'
-version: '1.0.3'
+version: '1.0.4'
 profile: 'integration_tests'
 config-version: 2
 

diff --git a/models/ad_reporting_models.yml b/models/ad_reporting_models.yml
@@ -143,7 +143,7 @@ models:
           combination_of_columns:
             - platform
             - date_day
-            - keyword_text
+            - keyword_id
             - keyword_match_type
             - ad_group_id
             - campaign_id
@@ -167,10 +167,10 @@ models:
         description: '{{ doc("ad_group_name") }}'
       - name: keyword_id
         description: '{{ doc("keyword_id") }}'
-      - name: keyword_text
-        description: '{{ doc("keyword_text") }}'
         tests:
           - not_null
+      - name: keyword_text
+        description: '{{ doc("keyword_text") }}'
       - name: keyword_match_type
         description: '{{ doc("keyword_match_type") }}'
       - name: clicks

diff --git a/models/intermediate/int_ad_reporting__keyword_report.sql b/models/intermediate/int_ad_reporting__keyword_report.sql
@@ -80,7 +80,7 @@ twitter_ads as (
         field_mapping={
                 'ad_group_id': 'line_item_id',
                 'ad_group_name': 'line_item_name',
-                'keyword_id': 'null',
+                'keyword_id': 'keyword_id',
                 'keyword_text': 'keyword',
                 'keyword_match_type': 'null'
             },

diff --git a/packages.yml b/packages.yml
@@ -24,4 +24,4 @@ packages:
     version: [">=0.2.0", "<0.3.0"]
 
   - package: fivetran/twitter_ads
-    version: [">=0.5.0", "<0.6.0"]
+    version: [">=0.5.0", "<0.6.0"]