Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed punctuation #2266

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed punctuation #2266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d3c25f
Update README.md
mnaghd01 Dec 29, 2024
689170c
Merge pull request #1 from mnaghd01/fixingFullStops
mnaghd01 Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
🚨 The first 200 PRs get the holographic sticker shown below. PRs after will get a regular Fireship sticker until they run out.

📺 Watch [How to Submit a Pull Request in 100 Seconds](https://youtu.be/8lGpZkjnkt4) on YouTube
📺 Watch [How to Submit a Pull Request in 100 Seconds](https://youtu.be/8lGpZkjnkt4) on YouTube.

![Fireship Sticker](https://firebasestorage.googleapis.com/v0/b/fireship-app.appspot.com/o/assets%2Fsticker-holo.png?alt=media&token=b41ebeaf-d5e9-4823-a294-5b11e63d7284)

Expand All @@ -12,15 +12,15 @@ This project provides a node script that encrypts your mailing address with a pu

Note: You must have Node 10 installed locally.

1. fork this repo
1. `git clone` your fork url
1. enter the project and run `npm install`
1. create a new branch with `git checkout -b ilikefreestuff`
1. run `npm start` to encrypt your address
1. create a new file named `stickers/<your-github-username>.txt` and paste in the encrypted string
1. run `git add .` and `git commit -m "your-message"`
1. `git push origin ilikefreestuff`
1. open new pull request on Github
1. fork this repo.
1. `git clone` your fork url.
1. enter the project and run `npm install`.
1. create a new branch with `git checkout -b ilikefreestuff`.
1. run `npm start` to encrypt your address.
1. create a new file named `stickers/<your-github-username>.txt` and paste in the encrypted string.
1. run `git add .` and `git commit -m "your-message"`.
1. `git push origin ilikefreestuff`.
1. open new pull request on Github.

Your commit must contain **only 1 file**. Verify that you did not change any existing code before making your PR. Do not commit any automatically modified yarn or package-lock.json files.

Expand Down