Add fuse element infrastructure #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renaming + adding to install
pbrubeck
reviewed
Jan 10, 2025
pbrubeck
reviewed
Jan 10, 2025
FIAT/polynomial_set.py
Outdated
| # is extended to match the larger | ||
|
|
||
| sd = ref_el.get_spatial_dimension() | ||
| if A.get_embedded_degree() != B.get_embedded_degree(): |
There was a problem hiding this comment.
We need to check also for the continuity of the expansion sets. We throw a ValueError if they are different. This logic would only work for discontinuous expansion sets, and break if the expansion set continuity is "C1".
Suggested change
| if A.get_embedded_degree() != B.get_embedded_degree(): | |
| if A.get_embedded_degree() != B.get_embedded_degree() and continuity is None: |
pbrubeck
reviewed
Jan 10, 2025
| embedded_coeffs.append(numpy.append(coeff, [0 for i in range(diff)])) | ||
| embedded_coeffs = numpy.array(embedded_coeffs) | ||
| new_coeffs = numpy.array(list(embedded_coeffs) + list(higher.coeffs)) | ||
| else: |
There was a problem hiding this comment.
this case works if A and B have the same continuity and degree.
There was a problem hiding this comment.
I guess then this function still needs to handle the case where A and B are not discontinuous but don't have the same degree. I haven't encountered this yet but will add it as a note in the function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the code required to use a fuse element as the base for a FIAT element