-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Echo server #118
base: main
Are you sure you want to change the base?
feat: Echo server #118
Conversation
|
Name | Link |
---|---|
🔨 Latest commit | ed0f1f9 |
I've never heard of a Check Spelling job. What am I supposed to do to fix it? Do I do something outlined here? https://github.com/firecamp-dev/firecamp/actions/runs/6540867134/attempts/1#summary-17761524652 |
Add |
helped with a lot of the issues thanks. Still getting some though
Doesn't seem to like the keys. I can fix that by moving them to a separate file and ignoring that as well. |
Cleaned up the PR and fixed the spelling for the spelling jobs. |
@nkBrew Is this PR ready for review? I see you have put down a note in the description to cleanup chores. |
Yeah it's ready for review now. I'll update the description |
will try it this weekend!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested all APIs except cookies (as they are not supported in Firecamp yet). all looks good to me.
I have one question, Have you cross-checked echo server APIs from the PM collection? Any APIs are pending to be implemented in FC? please confirm :)
I cross checked the API endpoints that had |
sure @nkBrew take your time :) |
Hi @nkBrew, do you have a plan to finish pending routes in the coming days? |
@Nishchit14 Yeah, was able to do it. Just uploaded the changes. |
@nkBrew thank you for the update, eager to deploy the echo server on the production server :) |
Description:
Implemented controllers that implement the same functionality for Postman's echo server
The controllers in question cover
Auth
Cookies
Utilities
Time
Notes:
- I still have a bit of cleanup I want to do to deduplicate some stuff. Wanted to get the PR up for review though.Closes:
#106