Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mime_type for metadata method response #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

artur79
Copy link

@artur79 artur79 commented Sep 20, 2011

No description provided.

@fguillen
Copy link
Owner

Hello Artur,

Can you add a few tests (or modify any of the actual tests) to check this changes?

@artur79
Copy link
Author

artur79 commented Sep 22, 2011

sure
will do this at the evening or during the weekend, cuz have a lot of work
now. btw. thanks for sharing this gem, it saved me a lot of work :)

On Thu, Sep 22, 2011 at 12:14 PM, Fernando Guillen <
[email protected]>wrote:

Hello Artur,

Can you add a few tests (or modify any of the actual tests) to check this
changes?

Reply to this email directly or view it on GitHub:
#1 (comment)

@fguillen
Copy link
Owner

On Thu, Sep 22, 2011 at 12:45 PM, Artur
[email protected]
wrote:

sure

Perfect!

will do this at the evening or during the weekend, cuz have a lot of work
now.

Take your time, and don't put to much work on it, just a test checking
that the new metadata attributes are there, and the values are
consistent.

As you see the tests are very simple:

btw. thanks for sharing this gem, it saved me a lot of work :)

I'm glad to know :)

f.

Fernando Guillén
Freelance Web Developer
http://www.fernandoguillen.info
http://spainrb.org/fernando-guillen

@fguillen
Copy link
Owner

Artur,

Also it would be helpful to 'squashing' all your commits in only one
and send the pull request in only one commit.

This last point is not important so if you have a reason for making
this modification in multiple commits is alright for me.

f.

On Thu, Sep 22, 2011 at 1:13 PM, Fernando Guillen
[email protected] wrote:

On Thu, Sep 22, 2011 at 12:45 PM, Artur
[email protected]
wrote:

sure

Perfect!

will do this at the evening or during the weekend, cuz have a lot of work
now.

Take your time, and don't put to much work on it, just a test checking
that the new metadata attributes are there, and the values are
consistent.

As you see the tests are very simple:

btw. thanks for sharing this gem, it saved me a lot of work :)

I'm glad to know :)

f.

Fernando Guillén
Freelance Web Developer
http://www.fernandoguillen.info
http://spainrb.org/fernando-guillen

Fernando Guillén
Freelance Web Developer
http://www.fernandoguillen.info
http://spainrb.org/fernando-guillen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants