Add Typescript SDK docker name for IR migrations (#972)

fern-api · Dec 10, 2022 · ceb94ed · ceb94ed
1 parent 4af1163
commit ceb94ed
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/packages/cli/generation/ir-migrations/src/__test__/migrateIntermediateRepresentation.test.ts b/packages/cli/generation/ir-migrations/src/__test__/migrateIntermediateRepresentation.test.ts
@@ -55,7 +55,7 @@ describe("migrateIntermediateRepresentation", () => {
 
     it("runs migration if generator is equal to migration version", () => {
         const migrated = migrateIntermediateRepresentation({
-            generatorName: "fernapi/fern-typescript",
+            generatorName: "fernapi/fern-typescript-sdk",
             generatorVersion: "0.0.245",
             intermediateRepresentation: MOCK_IR_V2 as unknown as IntermediateRepresentation,
         });
@@ -72,7 +72,7 @@ describe("migrateIntermediateRepresentation", () => {
 
     it("runs migration if generator is less than migration version", () => {
         const migrated = migrateIntermediateRepresentation({
-            generatorName: "fernapi/fern-typescript",
+            generatorName: "fernapi/fern-typescript-sdk",
             generatorVersion: "0.0.244",
             intermediateRepresentation: MOCK_IR_V2 as unknown as IntermediateRepresentation,
         });
@@ -89,7 +89,7 @@ describe("migrateIntermediateRepresentation", () => {
 
     it("does not run migration if generator is great to migration version", () => {
         const migrated = migrateIntermediateRepresentation({
-            generatorName: "fernapi/fern-typescript",
+            generatorName: "fernapi/fern-typescript-sdk",
             generatorVersion: "0.0.246",
             intermediateRepresentation: MOCK_IR_V2 as unknown as IntermediateRepresentation,
         });

diff --git a/packages/cli/generation/ir-migrations/src/migrations/ir-v1/migrateFromV2ToV1.ts b/packages/cli/generation/ir-migrations/src/migrations/ir-v1/migrateFromV2ToV1.ts
@@ -4,7 +4,8 @@ import { AlwaysRunMigration, IrMigration } from "../../types/IrMigration";
 
 export const V2_TO_V1_MIGRATION: IrMigration<V2.ir.IntermediateRepresentation, V1.ir.IntermediateRepresentation> = {
     requiredForGeneratorVersions: {
-        "fernapi/fern-typescript": "0.0.245",
+        "fernapi/fern-typescript": AlwaysRunMigration,
+        "fernapi/fern-typescript-sdk": "0.0.245",
         "fernapi/fern-python": AlwaysRunMigration,
         "fernapi/fern-java": AlwaysRunMigration,
         "fernapi/fern-openapi": AlwaysRunMigration,

diff --git a/packages/cli/generation/ir-migrations/src/types/GeneratorName.ts b/packages/cli/generation/ir-migrations/src/types/GeneratorName.ts
@@ -1,5 +1,6 @@
 export const GeneratorName = {
     TYPESCRIPT: "fernapi/fern-typescript",
+    TYPESCRIPT_SDK: "fernapi/fern-typescript-sdk",
     JAVA: "fernapi/fern-java",
     PYTHON: "fernapi/fern-python",
     OPENAPI: "fernapi/fern-openapi",

diff --git a/packages/cli/generation/ir-migrations/src/types/IrMigration.ts b/packages/cli/generation/ir-migrations/src/types/IrMigration.ts
@@ -11,9 +11,9 @@ export interface IrMigration<NextVersion, PreviousVersion> {
      * if the targeted generator's version is less than or equal to its value in
      * requiredForGeneratorVersions, then this migration is needed.
      *
-     * if the targeted generator's version is greater than its value in this map,
-     * or the targeted generator's name is not in this map, then this migration
-     * is needed.
+     * if the targeted generator's version is greater than its value in this
+     * map, or the value in this map is `undefined`, then this migration is
+     * needed.
      *
      * if the targeted generator's version is AlwaysRunMigration, then this
      * migration is needed