CONTRIB-233: Add additional contributors (part 2/3) #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postamentovich
approved these changes
Nov 18, 2021
azinit
commented
Nov 18, 2021
Comment on lines
+156
to
+165
| { | ||
| "login": "niyazm524", | ||
| "name": "Niyaz", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/32315145?v=4", | ||
| "profile": "https://github.com/niyazm524", | ||
| "contributions": [ | ||
| "example", | ||
| "userTesting" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Экс-кортимовец, пилит примеры для Вью)
Comment on lines
+166
to
+187
| { | ||
| "login": "Postamentovich", | ||
| "name": "Viacheslav Zinovev", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/22918007?v=4", | ||
| "profile": "https://github.com/Postamentovich", | ||
| "contributions": [ | ||
| "design", | ||
| "userTesting", | ||
| "review" | ||
| ] | ||
| }, | ||
| { | ||
| "login": "GhostMayor", | ||
| "name": "Alexandr", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/25086934?v=4", | ||
| "profile": "https://vk.com/id29842440", | ||
| "contributions": [ | ||
| "ideas", | ||
| "userTesting", | ||
| "review" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Наши многоуважаемые ревьюеры 👀
Comment on lines
+188
to
+198
| { | ||
| "login": "kof", | ||
| "name": "Oleg Isonen", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/52824?v=4", | ||
| "profile": "https://medium.com/@oleg008", | ||
| "contributions": [ | ||
| "ideas", | ||
| "research", | ||
| "userTesting" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Инфлюенсер по многим идеям как ни крути
Comment on lines
+199
to
+225
| { | ||
| "login": "julieobolenskaya", | ||
| "name": "Julie Obolenskaya", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/80626513?v=4", | ||
| "profile": "https://github.com/julieobolenskaya", | ||
| "contributions": [ | ||
| "translation" | ||
| ] | ||
| }, | ||
| { | ||
| "login": "Imperyall", | ||
| "name": "Roman Tikhiy", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/24413052?v=4", | ||
| "profile": "https://github.com/Imperyall", | ||
| "contributions": [ | ||
| "userTesting", | ||
| "doc" | ||
| ] | ||
| }, | ||
| { | ||
| "login": "igorkamyshev", | ||
| "name": "Igor Kamyshev", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/26767722?v=4", | ||
| "profile": "https://kamyshev.me/", | ||
| "contributions": [ | ||
| "bug", | ||
| "doc" |
Comment on lines
+304
to
+311
| "login": "yesnoruly", | ||
| "name": "Roma Karvacky", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/64963734?v=4", | ||
| "profile": "https://github.com/yesnoruly", | ||
| "contributions": [ | ||
| "example" | ||
| ] | ||
| }, |
Comment on lines
+312
to
+331
| { | ||
| "login": "oas89", | ||
| "name": "Aleksandr Osipov", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/5285065?v=4", | ||
| "profile": "https://github.com/oas89", | ||
| "contributions": [ | ||
| "userTesting" | ||
| ] | ||
| }, | ||
| { | ||
| "login": "mg901", | ||
| "name": "Maxim", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/7874664?v=4", | ||
| "profile": "https://t.me/mg901", | ||
| "contributions": [ | ||
| "userTesting" | ||
| ] | ||
| }, | ||
| { | ||
| "login": "Kelin2025", |
There was a problem hiding this comment.
Волна людей, кто давал регулярно фидбек
Comment on lines
+376
to
+392
| { | ||
| "login": "ledeneveugene", | ||
| "name": "Eugene Ledenev", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/51231845?v=4", | ||
| "profile": "https://github.com/ledeneveugene", | ||
| "contributions": [ | ||
| "data" | ||
| ] | ||
| }, | ||
| { | ||
| "login": "vladislavromanov", | ||
| "name": "Vladislav Romanov", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/63917524?v=4", | ||
| "profile": "https://github.com/vladislavromanov", | ||
| "contributions": [ | ||
| "data" | ||
| ] |
There was a problem hiding this comment.
В ишьюсы доп материал и фидбек кидали в помощь
Comment on lines
+283
to
+287
| <tr> | ||
| <td align="center"><a href="https://github.com/niyazm524"><img src="https://avatars.githubusercontent.com/u/32315145?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Niyaz</b></sub></a><br /><a href="#example-niyazm524" title="Examples">💡</a> <a href="#userTesting-niyazm524" title="User Testing">📓</a></td> | ||
| <td align="center"><a href="https://github.com/Postamentovich"><img src="https://avatars.githubusercontent.com/u/22918007?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Viacheslav Zinovev</b></sub></a><br /><a href="#design-Postamentovich" title="Design">🎨</a> <a href="#userTesting-Postamentovich" title="User Testing">📓</a> <a href="https://github.com/feature-sliced/documentation/pulls?q=is%3Apr+reviewed-by%3APostamentovich" title="Reviewed Pull Requests">👀</a></td> | ||
| <td align="center"><a href="https://vk.com/id29842440"><img src="https://avatars.githubusercontent.com/u/25086934?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Alexandr</b></sub></a><br /><a href="#ideas-GhostMayor" title="Ideas, Planning, & Feedback">🤔</a> <a href="#userTesting-GhostMayor" title="User Testing">📓</a> <a href="https://github.com/feature-sliced/documentation/pulls?q=is%3Apr+reviewed-by%3AGhostMayor" title="Reviewed Pull Requests">👀</a></td> | ||
| <td align="center"><a href="https://medium.com/@oleg008"><img src="https://avatars.githubusercontent.com/u/52824?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Oleg Isonen</b></sub></a><br /><a href="#ideas-kof" title="Ideas, Planning, & Feedback">🤔</a> <a href="#research-kof" title="Research">🔬</a> <a href="#userTesting-kof" title="User Testing">📓</a></td> |
There was a problem hiding this comment.
Ну и авторендерилка as-is
|
Опять пытался явно добавить лейблы типа "ТОП-ревьювер", "Создатель" - но там оч ущербно темплейт задается Вот максимум до чего дошел: Так шо лучше на уровне сайта с докой лучше определим |
azinit
requested review from
AlexandrHoroshih,
GhostMayor,
spotsccc and
unordinarity
Кроме того в сайте можно где-то наподалёку от аватарок контрибьюторов нарисовать логотипы спонсоров |
unordinarity
approved these changes
Nov 18, 2021
@unordinarity Ага, у вью и chakra-ui так и сделано
|
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Вторая итерация по задаче - добавление всех остальных контрибьюторов
#233
Чеклист