Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONFIG PROMOTE] Add social preview & System preferenced theme #250

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

azinit
Copy link
Member

@azinit azinit commented Aug 29, 2021

DISCLAIMER

Base-ветку выбрал для меньшего диффа
(как аппрувните, волью все разом, поменяв на мастер)

CHANGELOG

  • Добавил system preferenced theme

    Решалось одной булей в конфиге, лул

    (сорян за пример, я виндовод)

fs.-.system-preferenced.theme.mp4

Чеклист

  • Если при работе с документацией потребовалось использовать github-дискуссии, то стоит их прикрепить как see-also источники
  • Если PR связан с задачей, то необходимо проверить, что все требования по задаче выполнены
  • Перед тем, как отправлять изменения на ревью, нужно провести self-review своих изменений
  • Перед тем, как отправлять изменения на ревью, нужно дождаться CI-проверок
  • Перед тем, как отправлять изменения на ревью, нужно дать краткое описание изменений

@azinit azinit marked this pull request as draft August 29, 2021 23:27
@azinit azinit changed the title Update meta (social preview) & System preferenced theme [CONFIG PROMOTE] Update meta (social preview) & System preferenced theme Aug 29, 2021
@azinit azinit changed the title [CONFIG PROMOTE] Update meta (social preview) & System preferenced theme [CONFIG PROMOTE] Add social preview & System preferenced theme Aug 30, 2021
@azinit azinit marked this pull request as ready for review August 30, 2021 00:39
@azinit azinit self-assigned this Aug 30, 2021
@azinit azinit added this to the 2.0.0-beta.2 milestone Aug 30, 2021
@azinit azinit removed this from the 2.0.0-beta.2 milestone Aug 30, 2021
Copy link
Member Author

@azinit azinit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-reviewed

@azinit azinit requested review from a team, ilyaagarkov, OlegBrony, AlexandrHoroshih, spotsccc, GhostMayor, Postamentovich and unordinarity and removed request for a team and ilyaagarkov August 30, 2021 00:45
Base automatically changed from chore/update-deps to master August 30, 2021 16:27
@azinit azinit merged commit 69ea237 into master Aug 30, 2021
@azinit azinit deleted the feat/add-og-meta-preview branch August 30, 2021 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants