-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SqueezeNet model with functional API #14
base: master
Are you sure you want to change the base?
Conversation
added python file and explanations to readme file
added cite info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the PR! A few minor comments.
|
||
- [Original Squeezenet](https://github.com/DeepScale/SqueezeNet) | ||
|
||
''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docstring should come at the top of the file.
''' | ||
|
||
TH_WEIGHTS_PATH = 'PATH/squeezenet_weights_th_dim_ordering_th_kernels.h5' | ||
TF_WEIGHTS_PATH = 'PATH/squeezenet_weights_tf_dim_ordering_tf_kernels.h5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where can the weights be downloaded?
|
||
def SqueezeNet(nb_classes, finetune=False, input_tensor=None, weights=None): | ||
'''Instantiate the SqueezeNet architecture, | ||
optionally loading weights pre-trained |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation issue?
return x | ||
|
||
|
||
def SqueezeNet(nb_classes, finetune=False, input_tensor=None, weights=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't weights
default to "imagenet"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general: please match the same constructor arguments as every other image classification model in the repo / in keras.applications
: (include_top=True, weights='imagenet', input_tensor=None)
|
Sorry for the delay. I do intend on merging this, I just have limited bandwidth. |
@rcmalli do you think if it would be a good idea to add also head-less versions of the architecture (see, e.g. ResNet50) so to ease the potential usage in transfer learning? |
TO-DO
Reference:
Keras Project Reference:
Original Project Reference: