Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to parsing of pytorch models when using torch functionals #1143

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

JanFSchulte
Copy link
Contributor

A# Description

When torch functionals are used for pooling and flatten operations, some arguments were not correctly caught (or in the case of flatten, this type of usage was not supported at all). This PR fixes these issues.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

The example model in https://github.com/pytorch/examples/blob/main/mnist/main.py would fail to parse before, and now succeeds, modulo the not supported log_softmax activiation in the end.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@JanFSchulte JanFSchulte added the please test Trigger testing by creating local PR branch label Dec 6, 2024
@jmitrevs jmitrevs added the bug label Dec 6, 2024
@jmitrevs jmitrevs added this to the v1.0.0 milestone Dec 6, 2024
@jmitrevs jmitrevs removed the please test Trigger testing by creating local PR branch label Dec 6, 2024
@JanFSchulte JanFSchulte added the please test Trigger testing by creating local PR branch label Dec 6, 2024
@jmitrevs jmitrevs merged commit f377fe0 into fastmachinelearning:main Dec 6, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants