Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libsinsp/runc): augument containerd filter #2242

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

therealbobo
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 20, 2025

LGTM label has been added.

Git tree hash: 1f31ad773ad9ae2c2311e965f4eb7663f5e10ad6

@FedeDP
Copy link
Contributor

FedeDP commented Jan 20, 2025

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 20, 2025
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Perf diff from master - unit tests

     7.76%     +1.04%  [.] sinsp_evt::get_type
     1.48%     +0.43%  [.] sinsp::fetch_next_event
     3.96%     -0.35%  [.] gzfile_read
     1.03%     -0.34%  [.] sinsp_parser::parse_context_switch
     2.74%     -0.34%  [.] sinsp_parser::process_event
     1.33%     +0.29%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     2.16%     -0.23%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.82%     -0.22%  [.] 0x00000000000fd5c0
     0.35%     -0.19%  [.] sinsp_threadinfo::~sinsp_threadinfo
     1.45%     +0.19%  [.] sinsp_evt_filter::sinsp_evt_filter

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0693         -0.0694           152           141           152           141
BM_sinsp_split_median                                          -0.0784         -0.0784           153           141           153           141
BM_sinsp_split_stddev                                          -0.6750         -0.6756             3             1             3             1
BM_sinsp_split_cv                                              -0.6508         -0.6514             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0034         -0.0034            57            56            57            56
BM_sinsp_concatenate_paths_relative_path_median                -0.0308         -0.0308            58            56            58            56
BM_sinsp_concatenate_paths_relative_path_stddev                -0.9404         -0.9407             3             0             3             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.9402         -0.9405             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0550         -0.0550            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0529         -0.0529            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7551         -0.7552             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7408         -0.7410             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0548         -0.0548            61            58            61            58
BM_sinsp_concatenate_paths_absolute_path_median                -0.0761         -0.0761            63            58            63            58
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.6709         -0.6709             4             1             4             1
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.6519         -0.6519             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0143         -0.0143           393           387           393           387
BM_sinsp_split_container_image_median                          -0.0122         -0.0122           393           388           393           388
BM_sinsp_split_container_image_stddev                          +0.3352         +0.3338             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.3546         +0.3532             0             0             0             0

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.12%. Comparing base (ce530b5) to head (e531ed7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2242   +/-   ##
=======================================
  Coverage   75.11%   75.12%           
=======================================
  Files         276      276           
  Lines       34400    34400           
  Branches     5922     5921    -1     
=======================================
+ Hits        25841    25843    +2     
+ Misses       8559     8557    -2     
Flag Coverage Δ
libsinsp 75.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poiana poiana merged commit 7e48bed into falcosecurity:master Jan 20, 2025
49 checks passed
@FedeDP FedeDP mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants