Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libsinsp): allow reading scap from stdin #2241

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

therealbobo
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copy link

Perf diff from master - unit tests

     9.54%     +3.14%  [.] sinsp_parser::reset
     1.20%     +1.93%  [.] sinsp::fetch_next_event
     9.10%     -1.08%  [.] sinsp_evt::get_type
     5.72%     -0.83%  [.] next_event_from_file
     1.25%     +0.64%  [.] libsinsp::sinsp_suppress::process_event
     0.52%     +0.59%  [.] scap_next
    11.01%     -0.54%  [.] sinsp::next
     3.95%     -0.51%  [.] gzfile_read
     2.15%     -0.44%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     0.75%     +0.38%  [.] sinsp_evt::get_direction

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0296         -0.0295           153           148           153           148
BM_sinsp_split_median                                          -0.0303         -0.0302           152           148           152           148
BM_sinsp_split_stddev                                          +0.4224         +0.4205             1             1             1             1
BM_sinsp_split_cv                                              +0.4658         +0.4637             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0859         -0.0858            61            56            61            56
BM_sinsp_concatenate_paths_relative_path_median                -0.0874         -0.0873            61            56            61            56
BM_sinsp_concatenate_paths_relative_path_stddev                +0.5641         +0.5651             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    +0.7110         +0.7120             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0509         -0.0509            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0481         -0.0480            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7027         -0.7018             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.6867         -0.6858             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1057         -0.1056            63            56            63            56
BM_sinsp_concatenate_paths_absolute_path_median                -0.1005         -0.1004            62            56            62            56
BM_sinsp_concatenate_paths_absolute_path_stddev                -0.6113         -0.6114             1             0             1             0
BM_sinsp_concatenate_paths_absolute_path_cv                    -0.5654         -0.5655             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0208         -0.0207           404           395           403           395
BM_sinsp_split_container_image_median                          -0.0209         -0.0208           404           396           404           396
BM_sinsp_split_container_image_stddev                          +0.3118         +0.3105             2             3             2             3
BM_sinsp_split_container_image_cv                              +0.3397         +0.3383             0             0             0             0

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.12%. Comparing base (cb93f4b) to head (696b880).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2241   +/-   ##
=======================================
  Coverage   75.11%   75.12%           
=======================================
  Files         276      276           
  Lines       34394    34400    +6     
  Branches     5922     5921    -1     
=======================================
+ Hits        25836    25843    +7     
+ Misses       8558     8557    -1     
Flag Coverage Δ
libsinsp 75.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Jan 20, 2025

LGTM label has been added.

Git tree hash: 9af7085c5ce554a0555d47de20b7fd6c1d65cfee

@FedeDP
Copy link
Contributor

FedeDP commented Jan 20, 2025

/milestone 0.20.0

@poiana poiana added this to the 0.20.0 milestone Jan 20, 2025
@poiana poiana merged commit ce530b5 into falcosecurity:master Jan 20, 2025
49 checks passed
@FedeDP FedeDP mentioned this pull request Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants