-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: feat: add events dimensions file generator in modern probe #2232
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Leonardo Di Giovanna <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ekoops The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2232 +/- ##
=======================================
Coverage 75.09% 75.09%
=======================================
Files 276 276
Lines 34391 34391
Branches 5927 5927
=======================================
Hits 25826 25826
Misses 8565 8565
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/milestone 0.21.0 |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area build
/area driver-modern-bpf
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This PR enables automatic generation of
driver/modern_bpf/definitions/events_dimensions.h
. The new generator, defined indriver/modern_bpf/definitions/generator/generator.cpp
, is called by the build system if any modification to the event table is detected. The generated code is formatted usingclang-format
, with the configuration taken from.clang-format
, as in the rootMakefile
. The events dimensions file has been added as a separate dependency to the bpf object file targets.Which issue(s) this PR fixes:
#2227
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: