-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(driver): add a check on the SCHEMA version compatibility #2228
fix(driver): add a check on the SCHEMA version compatibility #2228
Conversation
Signed-off-by: Andrea Terzolo <[email protected]>
Please double check driver/API_VERSION file. See versioning. /hold |
Perf diff from master - unit tests
Heap diff from master - unit tests
Heap diff from master - scap file
Benchmarks diff from master
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2228 +/- ##
==========================================
- Coverage 75.44% 75.06% -0.39%
==========================================
Files 265 267 +2
Lines 34057 34259 +202
Branches 5801 5929 +128
==========================================
+ Hits 25695 25716 +21
- Misses 8362 8543 +181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/cc @leogr |
Setting milestone 0.20.0, we can move it to 0.21.0 if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
if(driver_minor != required_minor) { | ||
return scap_errprintf(error, | ||
0, | ||
"Scap and the legacy ebpf driver should have the same MINOR version. " | ||
"Ebpf MINOR '%lu' != Scap MINOR '%lu'", | ||
driver_minor, | ||
required_minor); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
LGTM label has been added. Git tree hash: 3c0d234edab400c4980b1ffb294b253f4a8cb8bd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area API-version
Does this PR require a change in the driver versions?
Not sure, maybe we want to bump a major in the API just to be sure we always enforce the new check?
What this PR does / why we need it:
This PR should provide a mitigation for this #1283 (comment)
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: