Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add an empty run for scap file before perf'ing it. #1977

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Jul 29, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Add a step where the scap file gets loaded (read by sinsp-example) before perfing it, so that we get more stable results.
Also, removed /dev/shm tmpfs workaround introduced in #1975

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor Author

FedeDP commented Jul 29, 2024

/milestone 0.18.0

@poiana poiana added this to the 0.18.0 milestone Jul 29, 2024
@poiana poiana added the size/S label Jul 29, 2024
Copy link

Perf diff from master - unit tests

     2.87%     +0.86%  [.] sinsp_thread_manager::find_thread
     0.91%     +0.82%  [.] sinsp::fetch_next_event
     1.53%     -0.81%  [.] 0x00000000000e83a0
     1.73%     +0.72%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
     2.35%     -0.63%  [.] scap_event_decode_params
     1.76%     -0.61%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     0.75%     +0.55%  [.] libsinsp::events::is_unknown_event
     4.54%     -0.54%  [.] sinsp_evt::load_params
     8.09%     +0.50%  [.] sinsp::next
     0.75%     -0.44%  [.] sinsp_split[abi:cxx11]

Perf diff from master - scap file

     5.01%     +6.16%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node
    25.08%     -5.56%  [.] sinsp_evt_formatter::tostring_withformat
    19.86%     +4.60%  [.] sinsp_filter_check::extract_nocache
     5.00%     +4.20%  [.] sinsp_filter_check::extract
    15.02%     -3.72%  [.] sinsp_filter_check_thread::extract_single
     5.01%     +2.14%  [.] sinsp::next
    10.01%     -1.81%  [.] sinsp_filter_check::get_transformed_field_info
    10.02%     +0.23%  [.] sinsp_filter_check::rawval_to_string
     4.98%     +0.06%  [.] std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::_M_realloc_insert<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.98%. Comparing base (64fe187) to head (e26d671).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1977   +/-   ##
=======================================
  Coverage   50.98%   50.98%           
=======================================
  Files         310      310           
  Lines       39612    39612           
  Branches    17333    17396   +63     
=======================================
  Hits        20197    20197           
+ Misses      14340    14330   -10     
- Partials     5075     5085   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit a118b0f into master Aug 8, 2024
45 of 46 checks passed
@poiana poiana deleted the chore/empty_run_scap_file branch August 8, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants