new(ci,docs): added heaptrack to our new perf related CI. #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poiana
added
release-note
kind/feature
|
/milestone 0.18.0 |
FedeDP
force-pushed
the
new/heaptrack
branch
4 times, most recently
from
089f429 to
e4aff9b
Compare
Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
commented
Jun 24, 2024
| @@ -214,9 +215,12 @@ TEST(sinsp_utils_test, sinsp_split_check_terminator) | |||
| // check that the null terminator is enforced | |||
| const char *in = "hello\0worlddd"; | |||
| size_t len = 13; | |||
| #ifdef _DEBUG | |||
| EXPECT_THROW(sinsp_split(in, len, '\0'), sinsp_exception); | |||
There was a problem hiding this comment.
In DEBUG mode this triggers a (well-known and desired) exception.
This fix allows to run tests on debug builds.
FedeDP
changed the title
Added a check on new leaks for heaptrack checks; moreover, changed perf checks to run against sum of diffs, that is more stable and useful. Ie: if part of logic gets moved from one method to another, we expect eg: method_A -> -7%, method_B -> +7%. Before, this triggered the CI error; now it does not, since the sum is 0. Signed-off-by: Federico Di Pierro <[email protected]>
Fails because it cannot find any master |
…table. Signed-off-by: Federico Di Pierro <[email protected]>
leogr
approved these changes
Jun 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area CI
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Adds
heaptracksupport to the new perf-related CI.Also, this improves threshold checks for
perf: they now run against sum of diffs, that is more stable and useful. Ie: if part of logic gets moved from one method to another, we expect eg:method_A -> -7%,method_B -> +7%. Before, this triggered the CI error; now it does not, since the sum is 0.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Heaptrack only tracks heap allocations; it cannot track stack allocations. Note this is the same default behavior as
valgrind massiftool, since stack tracking completely kill performances.Also, i chose heaptrack because:
perfdiffprofilesFor a comparison see: https://github.com/KDE/heaptrack?tab=readme-ov-file#comparison-to-valgrinds-massif
Does this PR introduce a user-facing change?: