fix(driver): fix build of kmod on linux 6.10. #1884
Conversation
poiana
added
release-note
do-not-merge/work-in-progress
kind/bug
|
/milestone next-driver |
Signed-off-by: Federico Di Pierro <[email protected]>
|
Kmod build is now ok: https://github.com/falcosecurity/libs/actions/runs/9300407315/job/25596333511 |
| !fd_is_open(close_fd, fdt) | ||
| #else | ||
| !test_bit(close_fd, fdt->open_fds) |
There was a problem hiding this comment.
can you add the commit link also here in the code? Thank you!
just asking myself if under the hood all three 3 methods use !test_bit(close_fd, fdt->open_fds) if yes we could directly remove the ifdefs 🤔
There was a problem hiding this comment.
That would be too hard to check on any supported kernel unfortunately :/ I'd avoid relying on any assumption :D
|
LGTM! I would just add the kernel commit link also in the code not just in the PR |
Signed-off-by: Federico Di Pierro <[email protected]>
|
Done, anyway, let's wait for at least 6.10-rc6 before unholding :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hey @FedeDP What's missing here? 🤔 |
FedeDP
changed the title
|
Green against rc7: https://github.com/falcosecurity/libs/actions/runs/9869833752/job/27254326144 |
|
/milestone 7.2.1+driver |
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area driver-kmod
Does this PR require a change in the driver versions?
What this PR does / why we need it:
torvalds/linux@c4aab26, included in linux 6.10-rc1, moved
fd_is_openaway from an header we can include.Therefore the proposed patch is to implement ourself the one-liner.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Keeping it as
wipuntil linux 6.10 is nearly released.I'll use this PR for tests if more changes are needed.
Does this PR introduce a user-facing change?: