-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(driver/bpf/filler_helpers.h) inconsistent int types #1460
cleanup(driver/bpf/filler_helpers.h) inconsistent int types #1460
Conversation
Signed-off-by: Everett Badeaux <[email protected]>
Signed-off-by: Everett Badeaux <[email protected]>
@ecbadeaux how many PRs are still pending, perhaps we can consolidate just a bit? To have maybe just 2-3PRs instead of 5+? |
@incertum I can gladly close this MR and knock them all out. I was keeping these MR's small so someone wouldn't have to read an XXXXXL merge request. Let me know what you'd prefer. Seems like you are the main reviewer anyways. |
Maybe partition changes over 2-3 PRs in total? This should probably be ok to review. You can decide on how to partition. |
@incertum Are we going to merge these or do you want me to close them? |
How about just re pushing on both and adding commits? We can review commit by commit. |
cleanup(bpf/fillers.h): create integer consistencies all types
Adding label Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Please double check driver/API_VERSION file. See versioning. /hold |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ecbadeaux The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@incertum I'll tag you again when all of this is ready to be reviewed. |
Sounds good, ah you need to remove the merge commit, always only use rebase. Ty! |
Signed-off-by: Everett Badeaux <[email protected]>
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closing to reopen with clean branch and commits (follow the conversation above) |
What type of PR is this?
/kind bug
/kind cleanup
Any specific area of the project related to this PR?
/area driver-bpf
Does this PR require a change in the driver versions?
No.
What this PR does / why we need it:
Make bpf code more consistent.
Which issue(s) this PR fixes:
part of #902
(partial fix other issues still remain in 902)
Special notes for your reviewer:
Does this PR introduce a user-facing change?: