Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userspace/libsinsp): properly inherit rawarg PT_DYN print format. #1428

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Oct 20, 2023

What type of PR is this?

/kind bug

Any specific area of the project related to this PR?

/area libsinsp

What this PR does / why we need it:

Fixes an issue preventing the print of rawarg.
Before:

sudo ./libsinsp/examples/sinsp-example -m -f "evt.type=setuid and evt.dir=>" -o "arg=%evt.rawarg.uid"
-- Filter AST (2) ppm sc names: setuid, setuid32
-- Try to open: 'modern_bpf' engine.
-- Engine 'modern_bpf' correctly opened.
-- Start capture
arg=
arg=
arg=

Because print_format is PF_NA.

After:

sudo ./libsinsp/examples/sinsp-example -m -f "evt.type=setuid and evt.dir=>" -o "arg=%evt.rawarg.uid"
-- Filter AST (2) ppm sc names: setuid, setuid32
-- Try to open: 'modern_bpf' engine.
-- Engine 'modern_bpf' correctly opened.
-- Start capture
arg=0
arg=1000
arg=1000

and print format is correctly set to PF_DEC.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(userspace/libsinsp): properly inherit rawarg PT_DYN print format.

@FedeDP FedeDP force-pushed the fix/inherit_rawarg_print_format branch from f0503a5 to 2419d94 Compare October 20, 2023 14:34
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 20, 2023

/milestone 0.14.0

@poiana poiana added this to the 0.14.0 milestone Oct 20, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 20, 2023

/cc @jasondellaluce @mstemm

@poiana poiana added size/S and removed size/XS labels Oct 20, 2023
Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

/approve

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit fa1265d into master Oct 23, 2023
@poiana poiana deleted the fix/inherit_rawarg_print_format branch October 23, 2023 08:19
@FedeDP FedeDP mentioned this pull request Oct 23, 2023
@FedeDP
Copy link
Contributor Author

FedeDP commented Oct 23, 2023

/milestone 0.13.3

@poiana poiana removed this from the 0.14.0 milestone Oct 23, 2023
@poiana poiana added this to the 0.13.3 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants