cleanup(scap,sinsp): return event flags directly #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grzegorz Nosek <[email protected]>
The device id does not necessarily correspond to the CPU id even for the kmod engine (when CPUs are offline). Rename the parameter to match reality a bit better. Signed-off-by: Grzegorz Nosek <[email protected]>
The event flags are (currently) specific to the savefile engine but accessing them requires an awkward reacharound through a dedicated vtable method to a field stored on each call to next(). We can simplify this a bit and express the intent better by simply returning the flags from next() via an out pointer. Signed-off-by: Grzegorz Nosek <[email protected]>
gnosek
force-pushed
the
return-event-flags-directly
branch
from
43eebdb to
9a4d0b1
Compare
|
LGTM label has been added. Git tree hash: 1bdbdcb9b0250c9cd70196decd70fcb4df046c89
|
|
/milestone 0.14.0 |
LucaGuerra
approved these changes
Oct 17, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, gnosek, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The event flags are (currently) specific to the savefile engine but accessing them requires an awkward reacharound through a dedicated vtable method to a field stored on each call to next().
We can simplify this a bit and express the intent better by simply returning the flags from next() via an out pointer.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libscap
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The "rename pcpuid to pdevid" commit is a pure no-op, the second one is where things happen (as well as changes in all the engines to switch to the new signature).
Also, I pulled in the unused variable fix from #1401 as well, since this breaks the build with -Werror otherwise.
Does this PR introduce a user-facing change?: