Added a human-readable final success message at end of tests #4247
+19
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that a human reading the test log can determine everything was fine without consulting the shell error code. Also: made `make check` slightly shorter by moving one longer test to `make test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A human just reading the test log, and unaware of shell's return code convention, will more easily determine that everything ran fine.
Answers #4245
Also:
make checkslightly shorter by moving one longer test tomake testshortesttarget, which was effectively the same thing ascheck(it was created before thechecktarget was implemented, and effectively deprecated for a pretty long time, seems safe to remove now)