Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix out-of-bounds array index access #4238

Merged
merged 2 commits into from
Jan 16, 2025
Merged

fix out-of-bounds array index access #4238

merged 2 commits into from
Jan 16, 2025

Conversation

szsam
Copy link
Contributor

@szsam szsam commented Jan 13, 2025

No description provided.

@facebook-github-bot
Copy link

Hi @szsam!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Cyan4973
Copy link
Contributor

Cyan4973 commented Jan 13, 2025

That's a good starting point !

Looking a bit more into it, if execution reaches this code path with idx == inSeqsSize,
it is probably better to return an error, because it means that input is invalid.
In contrast, current proposed fix just skips the if () {...} code block, and still returns a success, as if everything was fine.

@Cyan4973 Cyan4973 self-assigned this Jan 13, 2025
@Cyan4973 Cyan4973 merged commit 19025f3 into facebook:dev Jan 16, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants