Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix non-regular file test on GNU/Hurd #4212

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

diegonc
Copy link
Contributor

@diegonc diegonc commented Dec 10, 2024

Since commit b21b03ca6 [1] the behaviour of writes to /dev/zero has been fixed and now the non-regular file removal test no longer needs to be done on /dev/random (which no longer works as random is not writable now).

[1] https://git.savannah.gnu.org/cgit/hurd/hurd.git/commit/?id=b21b03ca624b89caeedfe58430cea4b40317d39f

Since commit b21b03ca6 [1] the behaviour of writes to /dev/zero has been
fixed and now the non-regular file removal test no longer needs to be
done on /dev/random (which no longer works as random is not writable now).

[1] https://git.savannah.gnu.org/cgit/hurd/hurd.git/commit/?id=b21b03ca624b89caeedfe58430cea4b40317d39f
@Cyan4973
Copy link
Contributor

which indirectly makes me wonder:
do we have a GNU/Hurd test on Github Actions ?
That sounds unlikely.
And in which case, should we add one ? How complex is it to setup ? and then to maintain ?

@Cyan4973
Copy link
Contributor

which indirectly makes me wonder: do we have a GNU/Hurd test on Github Actions ? That sounds unlikely. And in which case, should we add one ? How complex is it to setup ? and then to maintain ?

I had a quick look at it,
and, unless someone already did it and it's "just" a matter of copy paste,
it sounds like a nightmarish proposition to setup and maintain.
So, I guess we'll pass.

@Cyan4973 Cyan4973 merged commit 0218c8d into facebook:dev Dec 17, 2024
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants