Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elevated ZSTD_getErrorCode() to stable status #4184

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Conversation

Cyan4973
Copy link
Contributor

answering #4183.

Also:

  • updated manual, so that ZSTD_getErrorCode() is clearly mentioned in the paragraph dealing with handling of errors
  • updated version number, since this is technically a change of officially stable API

@Cyan4973 Cyan4973 self-assigned this Oct 31, 2024
@Cyan4973 Cyan4973 marked this pull request as ready for review October 31, 2024 21:17
@Cyan4973
Copy link
Contributor Author

Cyan4973 commented Oct 31, 2024

mmmh,
including zstd_errors.h from zstd.h
seems in conflict with our single file library build system...

edit : nope, hopefully, it's just the test of the single file library which is failing.

But it does illustrate the fact that, since zstd.h now includes zstd_errors.h after this patch,
both files, zstd.h and zstd_errors.h, are now required,
which could be surprising if the build has been created with the assumption that only zstd.h is enough.

copy "zstd_errors.h" alongside "zstd.h" to pass compilation test.
@Cyan4973 Cyan4973 merged commit 51eb7da into dev Nov 5, 2024
94 checks passed
@Cyan4973 Cyan4973 deleted the ZSTD_getErrorCode branch December 16, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants