Modify benchmark to load sources only once #4174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long time ago, after a regrettable update, the benchmark module ended up reloading sources for every output line, i.e. every compression level.
While the loading delay itself is likely tolerable,
the main issue is that the
--quiet
mode now also displays a loading summary between each compression line.This wasn't the original intention, which is to produce a compact view of all compression results.
This is fixed in this version,
where sources are loaded only once, for all compression levels, and loading summary is now only displayed once, as intended.
Before (
dev
) :fixed in this PR :