Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added android-ndk-build #4109

Merged
merged 1 commit into from
Aug 8, 2024
Merged

added android-ndk-build #4109

merged 1 commit into from
Aug 8, 2024

Conversation

Cyan4973
Copy link
Contributor

@Cyan4973 Cyan4973 commented Jul 30, 2024 •
edited
Loading

Adding an Android NDK build test.

It fails, as expected, due to lack of qsort_r() symbol.

The issue should be fixed after rebasing on top of @Adenilson 's #4107

@Cyan4973 Cyan4973 self-assigned this Jul 30, 2024
@Adenilson
Copy link

That is pretty awesome!

@Cyan4973
Copy link
Contributor Author

And as expected, the new NDK test works fine after integrating #4107.
So we have a good new test, able to catch similar Android NDK compilation issues in the future.

@Cyan4973 Cyan4973 merged commit 9a5c74b into dev Aug 8, 2024
95 checks passed
@Cyan4973 Cyan4973 deleted the actionsTest branch September 3, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Cyan4973 Cyan4973

Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cyan4973 @Adenilson @facebook-github-bot