Set lower bound for nbthreads default to 1

facebook · Dec 11, 2024 · 08590d2 · 08590d2
1 parent 2a8502e
commit 08590d2
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/programs/zstdcli.c b/programs/zstdcli.c
@@ -20,10 +20,6 @@
 #  define ZSTDCLI_CLEVEL_MAX 19   /* without using --ultra */
 #endif
 
-#ifndef ZSTDCLI_NBTHREADS_DEFAULT
-#define ZSTDCLI_NBTHREADS_DEFAULT (UTIL_countLogicalCores() / 4 > 4 ? 4 : UTIL_countLogicalCores() / 4)
-#endif
-
 /*-************************************
 *  Dependencies
 **************************************/
@@ -762,6 +758,9 @@ static int init_cLevel(void) {
 #ifdef ZSTD_MULTITHREAD
 static unsigned default_nbThreads(void) {
     const char* const env = getenv(ENV_NBTHREADS);
+    unsigned nbthreads_default = UTIL_countLogicalCores() / 4;
+    if (nbthreads_default < 1) nbthreads_default = 1;
+    if (nbthreads_default > 4) nbthreads_default = 4;
     if (env != NULL) {
         const char* ptr = env;
         if ((*ptr>='0') && (*ptr<='9')) {