Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lexical-selection] Fix __language in null #6747

Closed
wants to merge 2 commits into from

Conversation

ivailop7
Copy link
Collaborator

@ivailop7 ivailop7 commented Oct 20, 2024

5th highest error we are observing is: 'Cannot use 'in' operator to search for __language in null'
Not being able to reproduce, but confident the below should address this error in particular, since it seems like the only place in the code base we call '__language'

Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 10:33pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2024 10:33pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 20, 2024
@ivailop7 ivailop7 added the extended-tests Run extended e2e tests on a PR label Oct 20, 2024
Copy link

github-actions bot commented Oct 20, 2024

size-limit report 📦

Path Size
lexical - cjs 29.94 KB (0%)
lexical - esm 29.78 KB (0%)
@lexical/rich-text - cjs 38.51 KB (0%)
@lexical/rich-text - esm 31.58 KB (0%)
@lexical/plain-text - cjs 37.16 KB (0%)
@lexical/plain-text - esm 29 KB (0%)
@lexical/react - cjs 40.29 KB (0%)
@lexical/react - esm 33 KB (0%)

@etrepum
Copy link
Collaborator

etrepum commented Oct 21, 2024

#6701 has a repro, this will certainly fix this exception but I think another one might happen because other invariants are being violated when this occurs #6701 (comment)

Copy link
Collaborator

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because it's an incremental improvement but I think this may just raise an exception elsewhere based on previous comment

@ivailop7
Copy link
Collaborator Author

I'll rebase to latest nightly and see where things are at, before merging this one. Will keep open for a week/two.

@ivailop7
Copy link
Collaborator Author

ivailop7 commented Nov 1, 2024

After rebasing to latest it's been 7 days without observing the error. This won't be needed it appears. Closing.

@ivailop7 ivailop7 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. extended-tests Run extended e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants