-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-selection] Fix __language in null #6747
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
#6701 has a repro, this will certainly fix this exception but I think another one might happen because other invariants are being violated when this occurs #6701 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because it's an incremental improvement but I think this may just raise an exception elsewhere based on previous comment
I'll rebase to latest nightly and see where things are at, before merging this one. Will keep open for a week/two. |
After rebasing to latest it's been 7 days without observing the error. This won't be needed it appears. Closing. |
5th highest error we are observing is: 'Cannot use 'in' operator to search for __language in null'
Not being able to reproduce, but confident the below should address this error in particular, since it seems like the only place in the code base we call '__language'