Skip to content

Commit

Permalink
Revert change to _implicitlyLogged field
Browse files Browse the repository at this point in the history
Summary: Don't explicitly pass a false value for_implicitlyLogged

Reviewed By: ryantobinmeta

Differential Revision: D67885040

fbshipit-source-id: 051dc1a573f109d6fb00717302e8d06b0f10b211
  • Loading branch information
maxalbrightmeta authored and facebook-github-bot committed Jan 7, 2025
1 parent b26b836 commit d3f37ef
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ class AppEvent : Serializable {
if (isImplicit) {
eventObject.put("_implicitlyLogged", "1")
} else {
eventObject.put("_implicitlyLogged", "0")
log(
LoggingBehavior.APP_EVENTS,
"AppEvents",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ class AppEventTest : FacebookPowerMockTestCase() {
assertThat(json?.getString("key4")).isEqualTo("value4")
}

@Test
fun testIsImplicitlyLogged() {
val appEvent = AppEventTestUtilities.getTestAppEvent()
val json = appEvent.getJSONObject()
assertThat(json.getString("_implicitlyLogged")).isEqualTo("0")
}

@Test
fun testAppEventSerializedChecksum() {
val appEvent1 = AppEventTestUtilities.getTestAppEvent()
Expand Down

0 comments on commit d3f37ef

Please sign in to comment.